-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test if in nbdev_repo & improve nbdev_export
err message
#1448
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
maybe you just want to use |
nbdev_export
err message
Looks like CI problems @hamelsmu ! :D |
@hamelsmu did you want to mark this draft, or is it ready? |
if procs: | ||
import nbdev.export | ||
procs = [getattr(nbdev.export, p) for p in L(procs)] | ||
import nbdev.export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My jupyter notebook got angry with the indentation here. So I fixed it FYI
@jph00 it is ready now 😄 |
@jph00 IIUC you suggested making this function public
But you still have to check if that path exists. The way to check if nbdev exists might not be as apparent to users so maybe a simple function that helps you check (which is named appropriately) is better, given its usefulness?
Also, I improved the error message with
nbdev_export