-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for 3.11 #1373
Merged
Merged
add support for 3.11 #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message ID: ***@***.***>Thanks for looking into this. I guess the best thing to do is to just find the bit of the repr that it consistent, and have the test confirm that is correct.
|
I think even that won't be possible. They've changed the entire docstring and they've even added a new arg ( # new in 3.11
e (value, names=None, module=None, qualname=None, type=None, start=1, boundary=None)
Create a collection of name/value pairs.
# in previous versions
e (value, names=None, module=None, qualname=None, type=None, start=1)
An enumeration. |
Message ID: ***@***.***>OK maybe just get rid of that test then...
|
Will do! |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@jph00 It's ready for review. |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello, I'm trying to add support for py3.11 for
nbdev
, I'm trying some stuff on my fork. The PR will also eventually close #1372.I had a question for @jph00, there's only one test case which fails for 3.11 which is in
showdoc
. This has only come into existence because the docstring for the Enum was changed in 3.11. How should I try to handle the test case in such a situation? The test case is listed below,