uh oh something broke

.github/workflows/CBA.yml

@@ -34,7 +34,7 @@ jobs:
         ClangBuildAnalyzer --stop . buildAnalysis
     - name: Analyze
       run: ClangBuildAnalyzer --analyze buildAnalysis
-    - uses: actions/upload-artifact@v3.1.2
+    - uses: actions/upload-artifact@v4
       with:
         name: ClangBuildAnalyzer-traces
         path: "**/obj/*.json"

.github/workflows/astyle.yml

@@ -16,7 +16,7 @@ jobs:
         cancel_others: 'true'
         paths: '[".github/workflows/astyle.yml", "Makefile", ".astylerc", "**.cpp", "**.h", "**.c"]'
     - run: echo ${{ github.event.number }} > pull_request_id
-    - uses: actions/upload-artifact@v3.1.2
+    - uses: actions/upload-artifact@v4
       with:
         name: pull_request_id
         path: pull_request_id

.github/workflows/check-branch-name.yml

@@ -11,7 +11,7 @@ jobs:
     if: github.head_ref == 'master' && github.repository == 'CleverRaven/Cataclysm-DDA'
     steps:
       - name: Post warning
-        uses: actions/github-script@v6.3.3
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |

.github/workflows/clang-tidy.yml

@@ -84,7 +84,7 @@ jobs:
       run: bash ./build-scripts/requirements.sh
     - name: determine changed files
       if: ${{ github.event_name == 'pull_request' }}
-      uses: actions/github-script@v6.3.3
+      uses: actions/github-script@v7
       with:
         script: |
           var fs = require('fs');

.github/workflows/comment-commands.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set-up Comvent
-        uses: rytswd/comvent@v0.5.2
+        uses: rytswd/comvent@main
         id: comvent
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
@@ -65,7 +65,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set-up Comvent
-        uses: rytswd/comvent@v0.5.2
+        uses: rytswd/comvent@main
         id: comvent
         with:
           token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/detect-translation-file-changes.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Detect translation file changes"
-        uses: actions/github-script@v6.3.3
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |

.github/workflows/format_emscripten.yml

@@ -31,7 +31,7 @@ jobs:
         run: ls -a
 
       - name: Upload zipped html as artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: formatter
           path: formatter.html
@@ -40,7 +40,7 @@ jobs:
         with:
           ref: gh-pages
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v3.1.4
         with:
           name: formatter
 

.github/workflows/json.yml

@@ -16,7 +16,7 @@ jobs:
         cancel_others: 'true'
         paths: '["**.json", ".github/workflows/json.yml"]'
     - run: echo ${{ github.event.number }} > pull_request_id
-    - uses: actions/upload-artifact@v3.1.2
+    - uses: actions/upload-artifact@v4
       with:
         name: pull_request_id
         path: pull_request_id

.github/workflows/matrix.yml

@@ -333,18 +333,18 @@ jobs:
         echo ${{ github.event.number }} > pull_request_id
         echo "false" > ${{ env.ARCHIVE_SUCCESS }}
       if: ${{ env.ARCHIVE_SUCCESS && failure() }}
-    - uses: actions/upload-artifact@v3.1.2
+    - uses: actions/upload-artifact@v4
       if: ${{ always() && env.ARCHIVE_SUCCESS }}
       with:
         name: pull_request_id
         path: pull_request_id
-    - uses: actions/upload-artifact@v3.1.2
+    - uses: actions/upload-artifact@v4
       if: ${{ always() && env.ARCHIVE_SUCCESS }}
       with:
         name: ${{ env.ARCHIVE_SUCCESS }}
         path: ${{ env.ARCHIVE_SUCCESS }}
     - name: upload artifacts if failed
-      uses: actions/upload-artifact@v3.1.2
+      uses: actions/upload-artifact@v4
       if: failure()
       with:
         name: cata_test

.github/workflows/msvc-full-features.yml

@@ -68,7 +68,7 @@ jobs:
           make
 
     - name: Add msbuild to PATH
-      uses: microsoft/setup-msbuild@v1.3.1
+      uses: microsoft/setup-msbuild@v2
 
     - name: Use GNU tar to enable zstd for actions/cache
       run: |
@@ -91,7 +91,7 @@ jobs:
         vcpkg integrate install --vcpkg-root '${{ runner.workspace }}\b\vcpkg'
 
     - name: Download ccache
-      uses: robinraju/release-downloader@v1.4
+      uses: robinraju/release-downloader@v1.9
       with:
         repository: 'ccache/ccache'
         tag: 'v4.6.1'

.github/workflows/post-spell-check-result.yml

@@ -16,13 +16,13 @@ jobs:
       github.event.workflow_run.conclusion == 'success' }}
     steps:
       - name: Download pr id artifact
-        uses: dawidd6/action-download-artifact@v2
+        uses: dawidd6/action-download-artifact@v3.1.4
         with:
           workflow: ${{ github.event.workflow_run.name }}
           run_id: ${{ github.event.workflow_run.id }}
           name: pull_request_id
       - name: Download spell check retcode artifact
-        uses: dawidd6/action-download-artifact@v2
+        uses: dawidd6/action-download-artifact@v3.1.4
         with:
           workflow: ${{ github.event.workflow_run.name }}
           run_id: ${{ github.event.workflow_run.id }}
@@ -32,14 +32,14 @@ jobs:
         run: echo "spell-check-retcode=$( cat spell_check_retcode )" >> $GITHUB_OUTPUT
       - name: Download spell check output artifact
         if: steps.set-spell-check-retcode.outputs.spell-check-retcode >= 1
-        uses: dawidd6/action-download-artifact@v2
+        uses: dawidd6/action-download-artifact@v3.1.4
         with:
           workflow: ${{ github.event.workflow_run.name }}
           run_id: ${{ github.event.workflow_run.id }}
           name: spell_check_output
       - name: 'Comment on PR'
         if: steps.set-spell-check-retcode.outputs.spell-check-retcode >= 1
-        uses: actions/github-script@v6.3.3
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |

.github/workflows/pull-translations.yml

@@ -15,7 +15,7 @@ jobs:
         run: |
           curl -sL https://github.com/transifex/cli/releases/download/v1.6.4/tx-linux-amd64.tar.gz | sudo tar zxvf - -C /usr/bin tx
       - name: "Delete existing i18n branch"
-        uses: actions/github-script@v6.3.3
+        uses: actions/github-script@v7
         with:
           github-token: ${{ secrets.TX_PR_CREATOR }}
           script: |

.github/workflows/release.yml

@@ -195,7 +195,7 @@ jobs:
         uses: lukka/get-cmake@latest
       - name: Install dependencies (windows msvc) (1/4)
         if: runner.os == 'Windows'
-        uses: microsoft/setup-msbuild@v1.3.1
+        uses: microsoft/setup-msbuild@v2
       - name: Install dependencies (windows msvc) (2/4)
         if: runner.os == 'Windows'
         uses: lukka/run-vcpkg@v11
@@ -297,7 +297,7 @@ jobs:
           (cd build && zip ../cdda-${{ matrix.artifact }}-${{ needs.release.outputs.timestamp }}.${{ matrix.ext }} *)
       - name: Login to GitHub Container Registry
         if: matrix.artifact == 'windows-objectcreator-x64' || matrix.artifact == 'linux-objectcreator-x64'
-        uses: docker/login-action@v2 
+        uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
@@ -357,7 +357,7 @@ jobs:
           mv Cataclysm.dmg cdda-${{ matrix.artifact }}-${{ needs.release.outputs.timestamp }}.dmg
       - name: Set up JDK 8 (android)
         if: runner.os == 'Linux' && matrix.android != 'none' && matrix.mxe == 'none'
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v4
         with:
           java-version: '11'
           distribution: 'adopt'   

.github/workflows/test_labeler.yml

@@ -24,7 +24,7 @@ jobs:
         fi
     - name: Download success artifact from basic build
       if: ${{ github.event.workflow_run.name == 'General build matrix' }}
-      uses: dawidd6/action-download-artifact@v2
+      uses: dawidd6/action-download-artifact@v3.1.4
       with:
         workflow: ${{ github.event.workflow_run.name }}
         run_id: ${{ github.event.workflow_run.id }}
@@ -33,7 +33,7 @@ jobs:
       id: set-basic-build-success
       run: echo "basic-build-success=$( cat basic-build )" >> $GITHUB_OUTPUT
     - name: Download pr id artifact
-      uses: dawidd6/action-download-artifact@v2
+      uses: dawidd6/action-download-artifact@v3.1.4
       with:
         workflow: ${{ github.event.workflow_run.name }}
         run_id: ${{ github.event.workflow_run.id }}
@@ -43,7 +43,7 @@ jobs:
       run: echo "pr-id=$( cat pull_request_id )" >> $GITHUB_OUTPUT
     - name: set-label
       if: ${{ github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.conclusion != 'skipped' || steps.set-basic-build-success.outputs.basic-build-success == 'true' }}
-      uses: actions/github-script@v6.3.3
+      uses: actions/github-script@v7
       with:
         script: |
             if ('${{ steps.set-pr-id.outputs.pr-id }}'.trim().length == 0) {
@@ -58,7 +58,7 @@ jobs:
             }
     - name: remove-label
       if: ${{ github.event.workflow_run.conclusion == 'failure' && steps.set-basic-build-success.outputs.basic-build-success != 'true' }}
-      uses: actions/github-script@v6.3.3
+      uses: actions/github-script@v7
       with:
         script: |
             if ('${{ steps.set-pr-id.outputs.pr-id }}'.trim().length == 0) {

.github/workflows/text-changes-analyzer.yml

@@ -68,15 +68,15 @@ jobs:
           wc -c spell_check_output | grep -o '[0-9]*' > spell_check_retcode
           echo "length=$(cat spell_check_retcode)" >> $GITHUB_OUTPUT
       - run: echo ${{ github.event.number }} > pull_request_id
-      - uses: actions/upload-artifact@v3.1.2
+      - uses: actions/upload-artifact@v4
         with:
           name: pull_request_id
           path: pull_request_id
-      - uses: actions/upload-artifact@v3.1.2
+      - uses: actions/upload-artifact@v4
         with:
           name: spell_check_retcode
           path: spell_check_retcode
-      - uses: actions/upload-artifact@v3.1.2
+      - uses: actions/upload-artifact@v4
         if: steps.get_length.outputs.length >= 1
         with:
           name: spell_check_output

data/credits/it_IT.credits

@@ -9,24 +9,24 @@
 <color_yellow>KorGgenT</color>- Rasoio professionale per yak.
 
 <color_white>Un ringraziamento speciale a:</color>
-<color_yellow>un altro simulacro</color>- Per essere intervenuto e aver svolto il duro lavoro.
-<color_yellow>Pantaloni bombastici</color>- Per aver arricchito il sistema di armatura e averci fatto sudare.
-<color_yellow>Fris0uman</color>- Per far funzionare i nostri frigoriferi.
-<color_yellow>John-Candlebury</color>- Per Hub01 e tutte le bellissime mappe.
-<color_yellow>comunque</color>- Per mappe parametriche e posizioni mutabili.
-<color_yellow>BrettDong</color> - For translations and analyzing weird bugs.
-<color_yellow>wapcaplet</color>- Per tutto ciò che riguarda la barra laterale.
-<color_yellow>ZhilkinSerg</color>- Per unire tutte le cose.
-<color_yellow>Rivetto-lo-Zombie</color>- Per aver mantenuto il record di una fusione al giorno.
-<color_yellow>Notte-Pryanik</color>- Per innumerevoli correzioni di bug e miglioramenti.
-<color_yellow>Qrox</color>- Per aver migliorato ulteriormente l'infrastruttura dell'interfaccia utente.
-<color_yellow>Ramza13</color>- Per trasformare JSON in un linguaggio completo.
+<color_yellow>anothersimulacrum</color> - Per tutto il lavoro svolto.
+<color_yellow>BombasticSlacks</color> - Per aver rifinito il sistema di armatura e per averci introdotto alla sudorazione.
+<color_yellow>Fris0uman</color>- Per aver fatto funzionare i frigoriferi.
+<color_yellow>John-Candlebury</color>- Per l'Hub01 e tutte le bellissime mappe.
+<color_yellow>jbytheway</color> - Per la generazione parametrica delle mappe e posizioni variabili.
+<color_yellow>BrettDong</color> - Per le traduzioni e l'analisi di bug strani.
+<color_yellow>wapcaplet</color>- Per tutto ciò che riguarda la sidebar.
+<color_yellow>ZhilkinSerg</color>- Per tutti i merge effettuati.
+<color_yellow>Rivet-the-Zombie</color> - Per aver mantenuto il record di un merge al giorno.
+<color_yellow>Night-Pryanik</color>- Per innumerevoli correzioni di bug e miglioramenti.
+<color_yellow>Qrox</color>- Per aver migliorato ulteriormente la UI.
+<color_yellow>Ramza13</color>- Per aver trasformato JSON in un linguaggio turing-completo.
 <color_yellow>Drew4484</color>- Per tutto l'acciaio.
-<color_yellow>LyleSY</color>- Per ancora più dinosauri.
-<color_yellow>irwiss</color>,<color_yellow>Maleclisse</color>,<color_yellow>Venera3</color>,<color_yellow>Mylie Daniels</color>,<color_yellow>andrei8l</color>,<color_yellow>mqrause</color>, E<color_yellow>Eltank</color>.
+<color_yellow>LyleSY</color>- Per tutti i dinosauri.
+<color_yellow>irwiss</color>, <color_yellow>Maleclypse</color>, <color_yellow>Venera3</color>, <color_yellow>MylieDaniels</color>, <color_yellow>andrei8l</color>, <color_yellow>mqrause</color>, and <color_yellow>Eltank</color>.
 
 <color_white>Ringraziamenti speciali in ambito artistico:</color>
-<color_yellow>Fris0uman</color>,<color_yellow>Golfavel</color>,<color_yellow>vetall812</color>,<color_yellow>Dandy-ragazzo</color>, e molti altri.
+<color_yellow>Fris0uman</color>, <color_yellow>Golfavel</color>, <color_yellow>vetall812</color>, <color_yellow>Dandy-boy</color>, and many more.
 
 <color_white>Per una lista completa dei contributori si prega di vedere:</color>
 <color_cyan>https://github.com/CleverRaven/Cataclysm-DDA/contributors</color>
@@ -36,14 +36,14 @@
 
 ******************************************************************************
 
-<color_white>Principali sviluppatori (<color_cyan>0.F</color>):</color>
+<color_white>Sviluppatori Principali (<color_cyan>0.F</color>):</color>
 <color_yellow>mlangsdorf</color> - Veicoli, barche, accampamenti e guide sul modding.
 <color_yellow>I-am-Erk</color> - L'eredità di Ultica vivrà per sempre.
 <color_yellow>KorGgenT</color> - Non so dove mettere le mie assi di legno.
 
 <color_white>Ringraziamenti speciali a (<color_cyan>0.F</color>):</color>
 <color_yellow>Aivean</color> - Per la performance straordinaria.
-<color_yellow>un altro simulacro</color>- Per avermi stancato.
+<color_yellow>anothersimulacrum</color> - Per avermi stancato.
 <color_yellow>comunque</color>- Per avermi fatto realizzare cose.
 <color_yellow>BrettDong</color> - Per il progetto di traduzione e altro.
 <color_yellow>Qrox</color> - Per aver trovato e mostrato i messaggi d'errore.
@@ -60,10 +60,10 @@
 
 ******************************************************************************
 
-<color_white>Principali sviluppatori (<color_cyan>0.E</color>):</color>
+<color_white>Sviluppatori Principali (<color_cyan>0.E</color>):</color>
 <color_yellow>mlangsdorf</color> - Veicoli, barche, accampamenti e guide sul modding.
-<color_yellow>Io sono Erk</color>- Ultica, dialoghi, NPC e disordine nelle cucine.
-<color_yellow>KorGgenT</color>- Magicismo e mal di pancia.
+<color_yellow>I-am-Erk</color> - Ultica, dialoghi, NPC e il disordine nelle cucine.
+<color_yellow>KorGgenT</color>- Magiclysm e mal di pancia.
 
 <color_white>Ringraziamenti speciali a (<color_cyan>0.E</color>):</color>
 <color_yellow>Narcotraffico</color>- Per la manutenzione del bot di creazione automatico Jenkins.

data/json/items/gunmod/barrel.json

@@ -19,8 +19,6 @@
     "blacklist_mod": [
       "crafted_suppressor",
       "filter_suppressor",
-      "bottle_suppressor",
-      "riv_suppressor",
       "shot_suppressor",
       "suppressor",
       "mp5sd_suppressor",

data/json/items/melee/swords_and_blades.json

@@ -319,7 +319,6 @@
       "blacklist_mod": [
         "crafted_suppressor",
         "filter_suppressor",
-        "bottle_suppressor",
         "shot_suppressor",
         "suppressor",
         "suppressor_compact",
@@ -391,7 +390,6 @@
       "blacklist_mod": [
         "crafted_suppressor",
         "filter_suppressor",
-        "bottle_suppressor",
         "shot_suppressor",
         "suppressor",
         "suppressor_compact",
@@ -451,7 +449,6 @@
       "blacklist_mod": [
         "crafted_suppressor",
         "filter_suppressor",
-        "bottle_suppressor",
         "shot_suppressor",
         "suppressor",
         "suppressor_compact",
@@ -1681,7 +1678,6 @@
       "blacklist_mod": [
         "crafted_suppressor",
         "filter_suppressor",
-        "bottle_suppressor",
         "shot_suppressor",
         "suppressor",
         "suppressor_compact",
@@ -3113,7 +3109,6 @@
       "blacklist_mod": [
         "crafted_suppressor",
         "filter_suppressor",
-        "bottle_suppressor",
         "shot_suppressor",
         "suppressor",
         "suppressor_compact",
@@ -3163,7 +3158,6 @@
       "blacklist_mod": [
         "crafted_suppressor",
         "filter_suppressor",
-        "bottle_suppressor",
         "shot_suppressor",
         "suppressor",
         "suppressor_compact",