Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloche food expiration #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vasilevp
Copy link

Fix cloches spawning old food by deferring stack creation to the time food is spawned in the world. This is accomplished by the use of Supplier pattern.

@vasilevp vasilevp changed the title Fix/cloche food expiration Fix cloche food expiration Oct 20, 2022
Copy link

@agilmore2 agilmore2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be split into separate classes per java file. I like the supplier usage. Thank you!

@vasilevp
Copy link
Author

Sure - I left the new class in the same file because I didn't really know where to best put it.

@Gaelmare
Copy link
Collaborator

Sure - I left the new class in the same file because I didn't really know where to best put it.

By convention, each standalone Java public class is in its own .java source file. If you want to make this chance and update your PR, let me know, otherwise I will eventually get to it.

@vasilevp
Copy link
Author

Sure - I left the new class in the same file because I didn't really know where to best put it.

By convention, each standalone Java public class is in its own .java source file. If you want to make this chance and update your PR, let me know, otherwise I will eventually get to it.

I feel like you'd be better equipped to reorganize this how you see fit. I'm not a Java dev by any means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants