Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): ensure that start.sh only runs cluster in background and server in foreground #123

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

wax911
Copy link
Member

@wax911 wax911 commented Apr 28, 2024

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure you've done the following:

  • Check that your branch is based on develop and targets develop (where applicable)
  • Pull request has tests (if applicable)
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved

Description

This would effectively prevent the container from shutting down prematurely when it has nothing is in the foreground

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (Improves existing functionality)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of
the Apache License.

…r in foreground

This would effectively prevent the container from shutting down prematurely when it has nothing is in the foreground
@wax911 wax911 force-pushed the hotfix/resolve-background-marker-for-startup branch from 024f0b6 to ece1b81 Compare April 28, 2024 20:56
@wax911 wax911 enabled auto-merge (squash) April 28, 2024 20:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved automated PR

@wax911 wax911 disabled auto-merge April 28, 2024 21:02
@wax911 wax911 merged commit 789a67b into develop Apr 28, 2024
8 checks passed
@wax911 wax911 deleted the hotfix/resolve-background-marker-for-startup branch April 28, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant