Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments of https://github.com/django-parler/django-parler/pull/216 #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shun-liang
Copy link

This PR aims to address the comments of django-parler#216

@codecov-io
Copy link

codecov-io commented Mar 10, 2018

Codecov Report

Merging #1 into master will increase coverage by 1.48%.
The diff coverage is 98.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   85.73%   87.22%   +1.48%     
==========================================
  Files          31       31              
  Lines        1900     1933      +33     
==========================================
+ Hits         1629     1686      +57     
+ Misses        271      247      -24
Impacted Files Coverage Δ
parler/tests/test_querysets.py 100% <100%> (ø) ⬆️
parler/managers.py 91.21% <100%> (+4.05%) ⬆️
parler/tests/testapp/models.py 94.32% <100%> (+0.57%) ⬆️
parler/utils/fields.py 96.29% <95.45%> (+69.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7ac0e...c06382f. Read the comment docs.

@shun-liang shun-liang force-pushed the reduce-number-of-db-queries branch 2 times, most recently from 09ffa1c to da47ae0 Compare March 10, 2018 13:58
@shun-liang shun-liang force-pushed the reduce-number-of-db-queries branch 2 times, most recently from f3c758b to 882d1b8 Compare March 11, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants