✨ Rewrites + fix dep to hotfixes #3
Conversation
…before sending it to the API + add more types + upgrade some dependencies and re-arrange version numbers
| */ | ||
| async (jwtToken: string, macAddress: string) => { | ||
| const response = await axiosInstance.get<DeviceInfoType>( | ||
| `device/${transformMacAddress(macAddress)}/info`, |
There was a problem hiding this comment.
This is the main change. Else it is indentation + whitespaces
floviolleau
changed the title
|
Thank you so much for taking the time to contribute to the library! I really appreciate the effort you put into this PR. 💖 While I can see you've made a variety of changes, it's generally best to focus on one specific improvement at a time in a pull request. For example, the changes to For future contributions, I'd recommend keeping PRs small and focused on a single topic or feature. This helps ensure that the changes are easier to review and are more likely to get merged. I'd love for you to amend the PR focusing just on the Thanks again for contributing, and I hope to see more of your work in the future! 🌟 |
This PR is for AndreMiras/edilkamin#4
It contains: