Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upper bound for pyzmq/jupyter_client for notebook<7 #202

Merged
merged 3 commits into from
Jul 28, 2023
Merged

upper bound for pyzmq/jupyter_client for notebook<7 #202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b83f9af
upper bound for pyzmq/jupyter_client for notebook<7
mcg1969 Jul 27, 2023
8d3793c
add 5.2.0 pin
mcg1969 Jul 28, 2023
3a247ba
tackle unpinned case
mcg1969 Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,8 +1027,15 @@ def patch_record_in_place(fn, record, subdir):

# notebook <5.7.6 will not work with tornado 6, see:
# https://github.com/jupyter/notebook/issues/4439
# notebook <7 will not work with pyzmq>=25 and jupyter_client>=8, see:
# https://github.com/jupyter/notebook/pull/6749
if name == "notebook":
replace_dep(depends, "tornado >=4", "tornado >=4,<6")
if int(version.split('.', 1)[0]) < 7:
replace_dep(depends, "pyzmq >=17", "pyzmq >=17,<25")
replace_dep(depends, "jupyter_client >=5.3.4", "jupyter_client >=5.3.4,<8")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like notebook version 5.0.0-6.0.1 ether pins to jupyter_client>=5.2.0 or doesn't pin at all. Do those need the upper bound as well? Or is some other constraint protecting us here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice most of these are built for old versions of python, but notebook-5.7.9-py38_0 might still slip through.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add that

replace_dep(depends, "jupyter_client >=5.2.0", "jupyter_client >=5.2.0,<8")
replace_dep(depends, "jupyter_client", "jupyter_client <8")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pins added in response to comment

# spyder 4.0.0 and 4.0.1 should include a lower bound on psutil of 5.2
# and should pin parso to 0.5.2.
Expand Down