Update to v24.9.2 #22
Conversation
recipe/.condarc
Outdated
There was a problem hiding this comment.
Should all of our recipes have this? I think I'm missing context on how this deprecation affects our repos.
There was a problem hiding this comment.
No, this is a conda-standalone specific problem: conda/conda-standalone#99
| folder: constructor_src # [win] | ||
|
|
||
| build: | ||
| number: 0 | ||
| ignore_run_exports: | ||
| - '*' | ||
| script_env: | ||
| - PYINSTALLER_CONDARC_DIR={{ RECIPE_DIR }} |
There was a problem hiding this comment.
| - PYINSTALLER_CONDARC_DIR={{ RECIPE_DIR }} | |
| - PYINSTALLER_CONDARC_DIR={{ RECIPE_DIR }} |
This logic is a little confusing to me. Is this pointing to the current recipe dir to retrieve the .condarc to pull from defaults or is it intended to point to the pyinstaller recipe dir?
There was a problem hiding this comment.
{{ RECIPE_DIR }} renders to the recipe directory of this feedstock. pyinstaller is not involved with this.
| folder: conda_src | ||
| patches: | ||
| - "{{ SRC_DIR | replace('\\', '/') }}/src/conda_patches/0001-Rename-and-replace-entrypoint-stub-exe.patch" | ||
| - "{{ SRC_DIR | replace('\\', '/') }}/src/conda_patches/0002-Manipulate-PATH-directly-instead-of-_call_ing-conda.patch" | ||
| - "{{ SRC_DIR | replace('\\', '/') }}/src/conda_patches/0003-Restrict-search-paths.patch" |
There was a problem hiding this comment.
This looks fine, but I am curious why testing is skipped for windows and why the paths do not follow those used for Windows (i.e. '' instead of '/')?
There was a problem hiding this comment.
Testing is performed on Windows.
Using forward slashes in recipe files is the correct format, but on Windows, {{ SRC_DIR }} uses Windows-style paths.
This reverts commit b08cbc0.
conda-standalone 24.9.2
Destination channel: defaults
Links
Explanation of changes:
.condarcfile to point todefaultssince automatically pointing todefaultsis deprecatedlibmambapywas pinned to 1.5.8 because 1.5.10 is not available on defaults.