Skip to content

Commit

Permalink
fix: call end() instead of cancel()on successful GRPC Client Stre…
Browse files Browse the repository at this point in the history
  • Loading branch information
AnWeber committed Mar 15, 2024
1 parent 4fb3d1f commit bd53d7d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
## [unreleased]

### Features
- add current symbol to filter result if symbol matches predicate (AnWeber/vscode-httpyac#265)

### Fix
- call `end()` instead of `cancel()`on successful GRPC Client Streaming (Anweber/vscode-httpyac#264)

## [6.11.5] (2023-02-27)

### Fix
Expand Down
6 changes: 1 addition & 5 deletions src/plugins/grpc/grpcRequestClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,7 @@ export class GrpcRequestClient extends models.AbstractRequestClient<GrpcClient |

public streamEnded(): void {
if (this.grpcStream instanceof Writable || this.grpcStream instanceof Duplex) {
if (this.grpcStream.cancel) {
this.grpcStream.cancel();
} else {
this.grpcStream.destroy();
}
this.grpcStream.end();
delete this.grpcStream;
}
}
Expand Down

0 comments on commit bd53d7d

Please sign in to comment.