Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

AMP-84238 Update Android dependency to get Advertising Id #968

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

falconandy
Copy link
Contributor

@falconandy falconandy commented Sep 12, 2023

Amplitude Developer Docs PR

Description

Replaces Android package used to get advertising Id: 'com.google.android.gms:play-services-ads -> com.google.android.gms:play-services-ads-identifier

Change type

  • Doc bug fix.
  • Doc update. Fixes AMP-84238.
  • New documentation.
  • Non-documentation related fix or update.

PR checklist:

  • My documentation follows the style guidelines of this project.
  • I previewed my documentation on a local server using mkdocs serve.
  • Running mkdocs serve didn't generate any failures.
  • I have performed a self-review of my own documentation.

@amplitude-dev-docs

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdownlint 2 0 0.34s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-968.d19s7xzcva2mw3.amplifyapp.com

Copy link
Contributor

@markzegarelli markzegarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why spell check is running on a file not in this PR. I will check on that separately.

@falconandy Let me know when you want to merge and I will push it.

@justin-fiedler justin-fiedler merged commit 65e89b2 into main Sep 12, 2023
4 checks passed
@justin-fiedler justin-fiedler deleted the AMP-84238-error-with-ads-dependency branch September 12, 2023 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants