This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
Javascriptsdk #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 11, 2022 09:28
Co-authored-by: Kevin Pagtakhan <[email protected]>
Co-authored-by: Kevin Pagtakhan <[email protected]>
Co-authored-by: Kevin Pagtakhan <[email protected]>
Co-authored-by: Kevin Pagtakhan <[email protected]>
yuhao900914
reviewed
Mar 21, 2022
| amplitude.getInstance().logEvent('event', null, successCallback, errorCallback); | ||
| ``` | ||
|
|
||
| ### `init` callbacks |
There was a problem hiding this comment.
Should we move this around the init function?
There was a problem hiding this comment.
Can you be more specific @yuhao900914
| You can configure Amplitude by passing an object as the third argument to the init: | ||
|
|
||
| ```js | ||
| amplitude.getInstance().init("API_KEY", null, { |
There was a problem hiding this comment.
Should we scandalize the "" and '' ?
There was a problem hiding this comment.
I don't know what you mean by "Scandalize" @yuhao900914
kevinpagtakhan
approved these changes
Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.