Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy specs local file refs #2046

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: copy specs local file refs #2046

merged 2 commits into from
Aug 23, 2024

Conversation

fpaul-1A
Copy link
Contributor

@fpaul-1A fpaul-1A commented Aug 9, 2024

Proposed change

When we copy the spec file before generating the SDK we are breaking the local relative paths referenced in the file.
The proposed change is to copy all the referenced files inside the SDK in a folder ./spec-local-references/ to have them versioned.
We also update the local references in the spec to look for these files.

Related issues

@fpaul-1A fpaul-1A marked this pull request as ready for review August 9, 2024 12:51
@fpaul-1A fpaul-1A requested a review from a team as a code owner August 9, 2024 12:51
@fpaul-1A fpaul-1A changed the title [draft] fix: copy specs local file refs fix: copy specs local file refs Aug 9, 2024
@fpaul-1A fpaul-1A enabled auto-merge August 9, 2024 15:11
@mrednic-1A mrednic-1A force-pushed the fix/spec-ref branch 2 times, most recently from 1e8d079 to 40b92ac Compare August 20, 2024 14:41
@fpaul-1A fpaul-1A added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit e00c5e3 Aug 23, 2024
28 checks passed
@fpaul-1A fpaul-1A deleted the fix/spec-ref branch August 23, 2024 06:04
cpaulve-1A added a commit that referenced this pull request Aug 27, 2024
## Proposed change

Cherry Pick fix of #2046

## Related issues

- 🐛 Fixes #2014 

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:@ama-sdk/schematics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: openapi-generator 7.4.0 fails to resolve refs to files
5 participants