-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy specs local file refs #2046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpaul-1A
changed the title
[draft] fix: copy specs local file refs
fix: copy specs local file refs
Aug 9, 2024
pginoux-1A
reviewed
Aug 13, 2024
packages/@ama-sdk/schematics/schematics/typescript/core/helpers/copy-referenced-files.ts
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Aug 14, 2024
packages/@ama-sdk/schematics/schematics/typescript/core/helpers/copy-referenced-files.ts
Show resolved
Hide resolved
packages/@ama-sdk/schematics/schematics/typescript/core/helpers/copy-referenced-files.spec.ts
Outdated
Show resolved
Hide resolved
mrednic-1A
force-pushed
the
fix/spec-ref
branch
2 times, most recently
from
August 20, 2024 14:41
1e8d079
to
40b92ac
Compare
kpanot
reviewed
Aug 21, 2024
mrednic-1A
force-pushed
the
fix/spec-ref
branch
from
August 21, 2024 07:11
40b92ac
to
a0b37c2
Compare
cpaulve-1A
approved these changes
Aug 21, 2024
kpanot
approved these changes
Aug 23, 2024
cpaulve-1A
added a commit
that referenced
this pull request
Aug 27, 2024
## Proposed change Cherry Pick fix of #2046 ## Related issues - 🐛 Fixes #2014 <!-- Please make sure to follow the contributing guidelines on https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When we copy the spec file before generating the SDK we are breaking the local relative paths referenced in the file.
The proposed change is to copy all the referenced files inside the SDK in a folder
./spec-local-references/
to have them versioned.We also update the local references in the spec to look for these files.
Related issues