Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to imporve conziseness and readebility #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor changes to imporve conziseness and readebility #5

wants to merge 1 commit into from

Conversation

doertydoerk
Copy link

  • replace UI related code with storyboard capabilities to reduce amount of code
  • introduces IBAction to launch popup view
  • move code out of viewDidLoad: and into showPopupView:(UIButton *)sender for lazy instantiation
  • alted method and ivar naming
  • accessing ivars via self. as I figured it's pointless to have getter/setter for non-public ivars and then bypassing them

@doertydoerk
Minor changes to imporve conziseness and readebility
1abc3e1 
- replace UI related code with storyboard capabilities to reduce amount of code
- introduces IBAction to launch popup view
- move code out of viewDidLoad: and into showPopupView:(UIButton *)sender for lazy instantiation
- alted method and ivar naming
- accessing ivars via self. as I figured it's pointless to have getter/setter for non-public ivars and then bypassing them
@doertydoerk
Copy link
Author

Nice job, mate! Will give you credit on Cocoa Controls once implemented in my app and available on the app store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doertydoerk