Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Cypress readme + adding note about exposed queryClient #1944

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

olemartinorg
Copy link
Contributor

Description

  • The Studio team will start using our exposed queryClient to make their preview refresh faster: Remove full reload of preview altinn-studio#12517
    • I'm adding a comment about this in our code, to make sure we don't just remove the queryClient (and break preview in Studio).
  • Refreshing the Cypress README.md to reflect the way I've been running Cypress for (pretty much) ever. The cy:... scripts probably worked fine on windows, and they're nice if you're just running all the tests always, but giving people the power of just running npx cypress ... will give them greater flexibility.
  • Removing dependencies only used for making these scripts cross-platform(!), which are not otherwise used in our project.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

… work) and updating the readme with some instructions that look more like the way I'm running Cypress locally. Removing dependencies needed just for this purpose.
@olemartinorg olemartinorg added kind/other Pull requests containing chores/repo structure/other changes ignore-for-release Pull requests to be ignored in release notes labels Mar 15, 2024
Ole Martin Handeland added 2 commits March 15, 2024 15:48
test/README.md Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@olemartinorg olemartinorg merged commit 16d6a6b into main Mar 18, 2024
9 checks passed
@olemartinorg olemartinorg deleted the chore/readme-changes branch March 18, 2024 11:24
@olemartinorg olemartinorg mentioned this pull request Apr 18, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Pull requests to be ignored in release notes kind/other Pull requests containing chores/repo structure/other changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants