-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Simplify autocomplete input for V3 #14262
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14262 +/- ##
=======================================
Coverage 95.51% 95.52%
=======================================
Files 1826 1829 +3
Lines 23786 23775 -11
Branches 2757 2754 -3
=======================================
- Hits 22720 22710 -10
+ Misses 808 807 -1
Partials 258 258 ☔ View full report in Codecov by Sentry. |
ec37a17
to
b080ddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
frontend/packages/ux-editor-v3/src/components/config/EditFormComponent.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor-v3/src/components/config/componentConfig.tsx
Show resolved
Hide resolved
…omponent.test.tsx Co-authored-by: andreastanderen <[email protected]>
Tested this locally now and it looks as expected and behaves as expected until I try to unset the property. I see that when I remove the |
You're right, @standeren. I'll fix the update function so that the property is removed when it receives an empty string. |
Tested again now. Everything works as expected. Added the |
Description
Replaced the old
EditAutocomplete
component in the V3 forms editor with a simpler one. This was necessary to remove the use ofasChild
in our code. The component was also overly complex; a simpleNativeSelect
should be enough for this field.Master
Spiller.inn.2024-12-11.134954.mp4
This branch
Spiller.inn.2024-12-11.123718.mp4
Note
Actually, the autocomplete property should support multiple values, so a multiselect combobox would be the most appropriate solution here. But this was not supported in the main branch, so we should create a separate issue to fix that. We also need to check if it is supported by Apps.
Related Issue(s)
Verification