-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork ux-editor package #12228
Fork ux-editor package #12228
Conversation
frontend/packages/ux-editor-v3/src/components/config/EditFormComponent.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/toolbar/ConditionalRenderingModal.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/toolbar/RuleModal.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/config/ConditionalRenderingComponent.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/config/ConditionalRenderingComponent.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/config/RuleComponent.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/config/RuleComponent.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/config/RuleComponent.tsx
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor-v3/src/components/config/RuleComponent.tsx
Dismissed
Show dismissed
Hide dismissed
<Modal | ||
isOpen={true} | ||
onRequestClose={() => { | ||
this.props.cancelEdit; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning
5b46cb5
to
241ff8b
Compare
241ff8b
to
7b2ea52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I suggest we ignore the warnings from the checks here, given that this change essentially only introduces a copy of the ux-editor package.
Description
Created a copy of the
ux-editor
package, namedux-editor-v3
, that is to be used with apps with the version 3 frontend. The logic for determining which package to use is placed withinfrontend/app-development/router/routes.tsx
.Related Issue(s)
Verification