Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork ux-editor package #12228

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fork ux-editor package #12228

merged 1 commit into from
Feb 1, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Feb 1, 2024

Description

Created a copy of the ux-editor package, named ux-editor-v3, that is to be used with apps with the version 3 frontend. The logic for determining which package to use is placed within frontend/app-development/router/routes.tsx.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates labels Feb 1, 2024
<Modal
isOpen={true}
onRequestClose={() => {
this.props.cancelEdit;

Check warning

Code scanning / CodeQL

Expression has no effect Warning

This expression has no effect.
@TomasEng TomasEng linked an issue Feb 1, 2024 that may be closed by this pull request
@TomasEng TomasEng marked this pull request as ready for review February 1, 2024 10:11
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 515 lines in your changes are missing coverage. Please review.

Comparison is base (2cfedf2) 87.82% compared to head (7b2ea52) 86.42%.

Files Patch % Lines
...omponents/config/ConditionalRenderingComponent.tsx 12.34% 71 Missing ⚠️
...rc/components/Elements/ConfigureLayoutSetPanel.tsx 16.66% 60 Missing ⚠️
...c/components/toolbar/ConditionalRenderingModal.tsx 31.11% 31 Missing ⚠️
...kages/ux-editor-v3/src/containers/FormDesigner.tsx 64.36% 31 Missing ⚠️
...-editor-v3/src/components/config/RuleComponent.tsx 21.62% 29 Missing ⚠️
...tor-v3/src/components/config/EditFormContainer.tsx 67.10% 22 Missing and 3 partials ⚠️
...v3/src/components/config/editModal/EditOptions.tsx 65.51% 18 Missing and 2 partials ⚠️
.../ux-editor-v3/src/components/toolbar/RuleModal.tsx 58.97% 14 Missing and 2 partials ⚠️
.../hooks/mutations/useUpdateFormComponentMutation.ts 69.81% 13 Missing and 3 partials ⚠️
frontend/packages/ux-editor-v3/src/App.tsx 76.92% 11 Missing and 1 partial ⚠️
... and 53 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12228      +/-   ##
==========================================
- Coverage   87.82%   86.42%   -1.41%     
==========================================
  Files         972     1188     +216     
  Lines       13835    18042    +4207     
  Branches     1707     2290     +583     
==========================================
+ Hits        12150    15592    +3442     
- Misses       1474     2163     +689     
- Partials      211      287      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I suggest we ignore the warnings from the checks here, given that this change essentially only introduces a copy of the ux-editor package.

@nkylstad nkylstad merged commit e13cf0a into main Feb 1, 2024
10 of 12 checks passed
@nkylstad nkylstad deleted the fork-ux-editor branch February 1, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/dependencies Used for issues or pull requests that are dependency updates solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis: How do we support different app versions in Studio
2 participants