Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Norwegian locale and time zones #598

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Add support for Norwegian locale and time zones #598

merged 2 commits into from
Jan 17, 2025

Conversation

HenningNormann
Copy link
Contributor

Description

  • Add support for Norwegian locale and time zones

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@HenningNormann HenningNormann merged commit 1e4593e into main Jan 17, 2025
11 checks passed
@HenningNormann HenningNormann deleted the feature/439-a2-migration-changes-24 branch January 17, 2025 12:57
@SandGrainOne
Copy link
Member

SandGrainOne commented Jan 17, 2025 •
edited
Loading

I've compared the result of a few requests before and after the change and I see no concern to worry.

I tested:

  • Get all applications
  • Get all instances for a party (user login)
  • Get single instance (user login)
  • Get specific data blob (Data blob did not have any date fields, but Storage isn't involved in serialization anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
area/data-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenningNormann @SandGrainOne