Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A2 migrations: Changed method name to confirm to callback expectations #588

Merged
merged 4 commits into from
Dec 19, 2024
Merged

A2 migrations: Changed method name to confirm to callback expectations #588

merged 4 commits into from
Dec 19, 2024

Conversation

HenningNormann
Copy link
Contributor

@HenningNormann HenningNormann commented Dec 18, 2024 •
edited
Loading

Description

  • Changed method name to confirm to callback expectations

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@HenningNormann HenningNormann merged commit 69273c4 into main Dec 19, 2024
10 of 11 checks passed
@HenningNormann HenningNormann deleted the feature/439-a2-migration-changes-20 branch December 19, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ahmed-Ghanam Ahmed-Ghanam Ahmed-Ghanam approved these changes

Assignees
No one assigned
Labels
area/data-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenningNormann @Ahmed-Ghanam