Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for missing language when fetching style sheet #518

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

HenningNormann
Copy link
Contributor

Description

For some a2 services there are style sheets for only one or two languages. This change loops through alternative languages when searching for the user's prereferred language fails.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)
0.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link
Member

@SandGrainOne SandGrainOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion from sonar source.

@HenningNormann HenningNormann merged commit f3fdfa9 into main Oct 4, 2024
8 of 9 checks passed
@HenningNormann HenningNormann deleted the feature/439-a2-migration-changes-10 branch October 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants