Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A2 migration changes 7 - filter migrated a2 instance from msg box search #497

Merged
merged 23 commits into from
Sep 18, 2024
Merged

A2 migration changes 7 - filter migrated a2 instance from msg box search #497

merged 23 commits into from
Sep 18, 2024

Conversation

HenningNormann
Copy link
Contributor

@HenningNormann HenningNormann commented Sep 16, 2024 •
edited
Loading

Description

  • Added new column altinnmainversion to storage.instances table and related search procedure storage.readinstancefromquery_v5
  • Added new index instances_partyid_altinnmainversion_lastchanged. This index should be applied manually to tt02 and prod before deployment to avoid startup problems after deploy.
  • Added MessageBoxQueryModel.FilterMigrated
  • Added InstanceQueryParameters.MainVersionInclude/Exclude parameters

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Ahmed-Ghanam and others added 20 commits September 2, 2024 08:43
@Ahmed-Ghanam
Move the request parameters to their own type
62cf017
@Ahmed-Ghanam
Encapsulating query parameters within a class
1dabfd7
@Ahmed-Ghanam
Make sonarcloud happy
54a69ef
@Ahmed-Ghanam
Update line ending
64df8a7
@Ahmed-Ghanam
Add a unit test to verify that the GetMessageBoxInstanceEvents method…
c118862 
… can handle and return a large number of events correctly.
@Ahmed-Ghanam
Improve the BuildQueryString to operate on properties associated with…
d819be9 
… attributes.

Update the GetInstance to keep track of continuationToken
@Ahmed-Ghanam
Replace the query parameter with a private variable
24b0110
@Ahmed-Ghanam
Remove the size parameter
d0dba64
@Ahmed-Ghanam
Delete the duplicated _size parameter
310b751
@Ahmed-Ghanam
Add the size parameter.
1359699 
Replace the parameter with a variable.
@Ahmed-Ghanam
Moved two SQL parameters to the query parameters class.
731e989
@Ahmed-Ghanam
Reuse the old function that was used to build the continuation token.
9f670f1
@Ahmed-Ghanam
Improve the code quality
c64c2a4
@Ahmed-Ghanam
Remove a duplicate schema declaration
3acdf04
@Ahmed-Ghanam
Fixed an issue with self and next links.
ba56bfa 
Code refactoring.
@Ahmed-Ghanam
Code refactoring
23c345d
@Ahmed-Ghanam
Hide the internal data members and make them visible to the unit test…
e7f783c 
…s project
@Ahmed-Ghanam
Skip the parameter if it holds null.
65f51a3
@HenningNormann
Merge from feature/27
d1368e9
@HenningNormann
- Added new column altinnmainversion to storage.instances table and r…
2a4d114 
…elated search procedure storage.readinstancefromquery_v5

- Added MessageBoxQueryModel.FilterMigrated
- Added InstanceQueryParameters.MainVersionInclude/Exclude parameters
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@HenningNormann HenningNormann merged commit cddf83f into main Sep 18, 2024
8 of 9 checks passed
@HenningNormann HenningNormann deleted the feature/439-a2-migration-changes-7 branch September 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
area/data-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenningNormann @SandGrainOne @Ahmed-Ghanam