Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes storage postgres interface and added repo integration tests #285

Merged
merged 70 commits into from
Dec 12, 2023
Merged

Bugfixes storage postgres interface and added repo integration tests #285

merged 70 commits into from
Dec 12, 2023

Conversation

HenningNormann
Copy link
Contributor

@HenningNormann HenningNormann commented Dec 5, 2023 •
edited
Loading

Contains #254

Description

  • Repo integration tests
  • Storage.readallformultipledataelement parameter fix
  • TelemetryClient nullability fix
  • GetAllAppTitles - removed trailing semicolon (is present in Cosmos implementation)
  • DeleteAllInstanceEvents, changed from nonquery to scalar
  • GetHardDeletedDataElements: made org test case insensitive

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@HenningNormann
Moved all filter logic in GetInstancesFromQuery into the database
b8e46b8
@HenningNormann
- Added index instances_partyid_lastchanged
d29bbdb 
- storage.readinstancefromquery fixes
- Removed postgres stuff from InstanceQueryHelper
- Rewrite of GetInstancesFromQuery
@HenningNormann
Fix for excludeConfirmedBy
f8ca1cd
@HenningNormann
- Forced default sort order in GetInstances
6523b1a 
- Restored db functions removed by mistake
- Added /fileScanResult av valid property when updating data element
@HenningNormann
Added more valid properties to update in data element
931d6cd
@HenningNormann
Merge from main
801bdab
@HenningNormann
Ensured that internalId is always sent to dataelement create.
fdd1ce4
@HenningNormann
Avoid ambigious reference to event
36c7b77
@HenningNormann
Avoid ambigious reference to event - take 2
d4c9622
@HenningNormann
Avoid ambigious reference to event - take 3
707537a
@HenningNormann
Changed delete procedures to functions to be able to return row count.
cd331c6
@HenningNormann
Fixed ListInstanceEvents
b496c28
@HenningNormann
Removed duplicate readasync
4ed3f17
@HenningNormann
Merge from main
7f9de23
@HenningNormann
Fixed unit test and sonarcloud change
03c613b
@HenningNormann
Fix for sonarcloud fix and extra condition in query instances db func…
ee1553f 
…tion
@HenningNormann
Case sensitive filtering of instance event event type
b8c9599
@HenningNormann
Renamed internalId to instanceInternalId
e6b1950
@HenningNormann
Merge from main
5c6a5f4
@HenningNormann
Moved blob functionality to new repository
353a7e4
@HenningNormann
Added CleanupController and related db logic. Cut-and-paste from exis…
f93972f 
…ting cosmos cleanup and reuse of existing code.
@HenningNormann
Added blob repository to the unit tests
2071363
@HenningNormann
- Changed http verb in cleanup controller from get to delete
17e521f 
- Renamed GetHardDeletedElements -> GetHardDeletedDataElements
@HenningNormann
Added CleanupController.CleanupInstancesForApp
d192cd8
@HenningNormann
Added app insights dependency tracking for postgres
82a401f
@HenningNormann
Merge from main
3029637
@HenningNormann
Avoid call to SetStatuses when no instances are found
cb6518a
@HenningNormann
Fix to avoid losing date query parameters when both "from" and "to" a…
c12458e 
…re included.
@HenningNormann
Merge from main
703ecab
@HenningNormann
Merge from main
a871278
@HenningNormann HenningNormann mentioned this pull request Dec 11, 2023
Closed
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.2% 38.2% Coverage
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.3% 38.3% Coverage
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@HenningNormann
- Made suggested changes to cleanupcontroller consistent
1df4eb9 
- Moved variables closer to use
- Made test data more consistent
- Removed unused code
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 11, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.6% 38.6% Coverage
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@HenningNormann HenningNormann merged commit 3381a7a into main Dec 12, 2023
9 of 10 checks passed
@HenningNormann HenningNormann deleted the feature/191-postgresql-poc-5 branch December 12, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenningNormann @SandGrainOne @acn-sbuad