Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some test for deployments mapping #898

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

tjololo
Copy link
Member

@tjololo tjololo commented Aug 30, 2024

Description

Had some time today so created som tests for the mapping of Deployments and Daemonsets response from kubeerneteswrapper to altinn.Deployments struct

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@tjololo tjololo requested a review from a team as a code owner August 30, 2024 13:01
@tjololo tjololo requested a review from khanrn September 10, 2024 09:46
@tjololo
Copy link
Member Author

tjololo commented Sep 24, 2024

@khanrn can you have another look and see if the new test strategy is ok?

@tjololo tjololo merged commit 083ad77 into main Sep 24, 2024
7 checks passed
@tjololo tjololo deleted the dais/add-deployments-tests branch September 24, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants