Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update organization for Dialogporten product #1195

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

arealmaas
Copy link
Contributor

@arealmaas arealmaas commented Dec 19, 2024

In an effort to transfer the repositories for Dialogporten to the Alinn organization, we need to change organization here from digdir to altinn

This is a pull-request that should be merged only after the transition has been done as part of Altinn/dialogporten#1144

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Summary by CodeRabbit

  • Chores
    • Updated ownership for the "Dialogporten" product from "digdir" to "Altinn"

In an effort to transfer the repositories for Dialogporten to the Alinn organization, we need to change organization here from `digdir` to `altinn`
Copy link

coderabbitai bot commented Dec 19, 2024

📝 Walkthrough

Walkthrough

The pull request involves a modification to the products.yaml file, specifically changing the owner of the "Dialogporten" product from digdir to Altinn. This change updates the ownership attribution for the product while maintaining the existing structure and other details of the file. No other entries or sections were modified during this update.

Changes

File Change Summary
products.yaml Updated owner for "Dialogporten" product from digdir to Altinn

Possibly related PRs

Suggested reviewers

  • sduranc

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 488be67 and 70f82be.

📒 Files selected for processing (1)
  • products.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • products.yaml

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arealmaas arealmaas marked this pull request as ready for review January 9, 2025 09:53
@arealmaas arealmaas requested a review from a team as a code owner January 9, 2025 09:53
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
products.yaml (1)

Line range hint 24-25: Consider updating the slug description

The slug 'DDP' is described as "Product DigDir Dialogporten" which still references DigDir. Consider updating this to reflect the new ownership.

-    slug: DDP # Product DigDir Dialogporten
+    slug: DDP # Product Dialogporten
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8024b9a and 488be67.

📒 Files selected for processing (1)
  • products.yaml (1 hunks)

products.yaml Outdated Show resolved Hide resolved
products.yaml Outdated Show resolved Hide resolved
Co-authored-by: Vemund Gaukstad <[email protected]>
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arealmaas
Copy link
Contributor Author

Får ikke til å merge denne selv., Kan du evt. bistå der @tjololo ?
CleanShot 2025-01-09 at 15 47 01@2x

@tjololo
Copy link
Member

tjololo commented Jan 9, 2025

Får ikke til å merge denne selv., Kan du evt. bistå der @tjololo ? CleanShot 2025-01-09 at 15 47 01@2x

yup, kjører pipeline også kan jeg merge om det ser ok ut

@tjololo
Copy link
Member

tjololo commented Jan 10, 2025

ah, from a fork so the vars are not available. Can this be merged and applied now @arealmaas ?

@arealmaas
Copy link
Contributor Author

Yes!

@tjololo tjololo merged commit 032cde2 into Altinn:main Jan 10, 2025
2 of 3 checks passed
@arealmaas arealmaas deleted the patch-1 branch January 10, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants