Add broker/corr as grafan editors #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Walkthrough<details>
<summary>📝 Walkthrough</summary>
## Walkthrough
The changes involve modifications to the Terraform configuration for Azure resources, specifically enhancing local variables related to developer groups for Grafana access. New local variables have been added to define additional developer groups, which are incorporated into the `grafana_editor` variable. The `for_each` loop for `grafana_editors` has been updated to include these new groups in the role assignment. The `grafana_admin` role assignment remains unchanged, and the `skip_service_principal_aad_check` parameter is consistently applied across all role assignments.
## Changes
| File Path | Change Summary |
|------------------------------------------------------------|----------------------------------------------------------------------------------------------------|
| infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf | - Added local variables: `altinn_30_broker_test_developers`, `altinn_30_broker_prod_developers`, `altinn_30_correspondence_prod_developer`, `altinn_30_correspondence_test_developer`.<br>- Updated local variable `grafana_editor` to include new groups.<br>- Updated `for_each` loop in `azurerm_role_assignment` for `grafana_editors` to reference `local.grafana_editor`.<br>- Updated local variable `grafana_admin` (no structural change).<br>- Consistent application of `skip_service_principal_aad_check` across role assignments. |
</details>Warning Rate limit exceeded@bengtfredh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf (1)
43-46: LGTM! Consider adding documentation comments.The new Azure AD group variables are well-structured with clear naming. Consider adding comments to document the purpose of each group for better maintainability.
+ # Azure AD group for broker team (test environment) altinn_30_broker_test_developers = "9b99f951-3873-4310-8baf-464b4da43f26" + # Azure AD group for broker team (production environment) altinn_30_broker_prod_developers = "7708786a-aa50-4ce8-9f7f-e85459357de1" + # Azure AD group for correspondence team (production environment) altinn_30_correspondence_prod_developer = "89627577-7e88-446b-a64b-699a9208343c" + # Azure AD group for correspondence team (test environment) altinn_30_correspondence_test_developer = "12b73376-8726-493c-8d27-aa87e5213e6b"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf(2 hunks)
🔇 Additional comments (2)
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf (2)
49-56: LGTM! Editor permissions properly configured.
The grafana_editor list correctly includes both existing and new developer groups, maintaining appropriate access control.
43-46: Verify Azure AD group IDs and test access
Please ensure:
- The Azure AD group IDs are correct and active
- Test access for both broker and correspondence teams in their respective environments
- Verify that the groups have the expected team members
Also applies to: 49-56
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf
Outdated
Show resolved
Hide resolved
Terraform environment testFormat and Style 🖌
|
| Context | Values |
|---|---|
| Pusher | @bengtfredh |
| Action | push |
| Working Directory | ./infrastructure/adminservices-test/altinn-monitor-test-rg |
| State File | github.com/altinn/altinn-platform/environments/test/altinn-monitor-test-rg.tfstate |
| Plan File | github.com_altinn_altinn-platform_environments_test_altinn-monitor-test-rg.tfstate.tfplan |
infrastructure/adminservices-test/altinn-monitor-test-rg/grafana.tf
Outdated
Show resolved
Hide resolved
monteiro-renato
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add broker and correspondence developers as grafana editors to grafana.altinn.cloud
Summary by CodeRabbit
New Features
Bug Fixes