Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/am UI/195 add new user org #1232

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Conversation

allinox
Copy link
Contributor

@allinox allinox commented Jan 21, 2025

image

Description

User can now add orgs to list of rightholders

The org is added by the user making a search through the already implemented org lookup and then confirming by clicking the add button. If the org is a subunit, it will be marked as such

In addition to this, a technical error component has been added that can be used to display the same technical error message multiple places. The message includes the time the error occurred and the status of the http call

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the kind/feature-request Used when issue is a new feature or request label Jan 21, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarQube Cloud

@allinox allinox requested a review from sonwit January 21, 2025 08:27
Copy link
Contributor

@sonwit sonwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I really like the new reusable error-message component!
I have no comments.
Approved ✅

@allinox allinox merged commit 893013d into main Jan 21, 2025
8 of 9 checks passed
@allinox allinox deleted the feat/amUI/195-add-new-user-org branch January 21, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request Used when issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants