Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: upgrade StyleCop.Analyzers package #1217

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Chore: upgrade StyleCop.Analyzers package #1217

merged 1 commit into from
Jan 14, 2025

Conversation

mgunnerud
Copy link
Contributor

@mgunnerud mgunnerud commented Jan 13, 2025 •
edited
Loading

Description

  • Upgrade StyleCop.Analyzers package
  • Fix reported issues

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mgunnerud mgunnerud linked an issue Jan 13, 2025 that may be closed by this pull request
Chore: Oppgrader StyleCop.Analyzers pakke #1216
Closed
2 tasks
@github-actions github-actions bot added the kind/chore Create a none user-story issue (chore, tech issue, backend issue) label Jan 13, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgunnerud mgunnerud marked this pull request as ready for review January 13, 2025 14:08
@mgunnerud mgunnerud requested review from sonwit and allinox January 13, 2025 14:33
allinox
allinox approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@allinox allinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job noticing and fixing this defect 🙌
It's good to know we're now using the same version as the other repos

@mgunnerud mgunnerud merged commit a3fbfd2 into main Jan 14, 2025
9 checks passed
@mgunnerud mgunnerud deleted the chore/1216-chore-oppgrader-stylecopanalyzers-pakke branch January 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allinox allinox allinox approved these changes

@sonwit sonwit Awaiting requested review from sonwit

Assignees
No one assigned
Labels
kind/chore Create a none user-story issue (chore, tech issue, backend issue)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Oppgrader StyleCop.Analyzers pakke
2 participants
@mgunnerud @allinox