-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding used by section #489
base: master
Are you sure you want to change the base?
Conversation
@sboldyreva do you think you can take this across the finish line? |
@bennyvasquez let me take a look |
Thanks @mattlasheboro for getting a version of the global layer logo done up. |
@bennyvasquez we can ask @Shone-Kristas to help with mobile version adjustments |
<h4 class="pb-2 border-bottom"> | ||
{{ i18n "Trusted by" }} | ||
</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h4 class="pb-2 border-bottom"> | |
{{ i18n "Trusted by" }} | |
</h4> | |
<h2 class="pb-2 text-center border-bottom"> | |
{{ i18n "Trusted by" }} | |
</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we have it h2 and centered as the rest sections on the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency is very good, for sure, and your suggestion is correct if we want to keep it.
As a note: I'm worried about how much space this title in addition to the logos adds to the page, though, and was considering dropping the text entirely here. That seemed consistent with what other organizations do when providing the same information (or maybe even change it to something a bit more verbose 'Our users come from industries across the globe').
However, I'm worried that it won't be clear what these logos represent without the text. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH! I like that a TON, actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this should do the job
<div class="al-index-backed-by al-py-lg" style="width: 100%; padding: 0 15px;">
<div class="container">
<h3 class="pb-2">
Trusted by
</h3>
<div class="row row-cols-2 row-cols-sm-4 row-cols-md-6 g-5 al-used-by-list ">
<div class="col d-flex flex-fill align-items-center justify-content-center al-used-by-logo-container">
<img loading="lazy" src="/usedby/akamai.svg" alt="akamai" class="al-used-by-logo" style="height: 100%; width: 120px;">
</div>
<div class="col d-flex flex-fill align-items-center justify-content-center al-used-by-logo-container">
<img loading="lazy" src="/usedby/arista.svg" alt="arista" class="al-used-by-logo" style="height: 100%; width: 120px;">
</div>
<div class="col d-flex flex-fill align-items-center justify-content-center al-used-by-logo-container">
<img loading="lazy" src="/usedby/colorodostateuniveristy.svg" alt="colorodostateuniveristy" class="al-used-by-logo" style="height: 100%; width: 120px;">
</div>
<div class="col d-flex flex-fill align-items-center justify-content-center al-used-by-logo-container">
<img loading="lazy" src="/usedby/hetzner.png" alt="hetzner" class="al-used-by-logo" style="height: 100%; width: 120px;">
</div>
<div class="col d-flex flex-fill align-items-center justify-content-center al-used-by-logo-container">
<img loading="lazy" src="/usedby/lacework.svg" alt="lacework" class="al-used-by-logo" style="height: 100%; width: 120px;">
</div>
<div class="col d-flex flex-fill align-items-center justify-content-center al-used-by-logo-container">
<img loading="lazy" src="/usedby/phoronix.svg" alt="phoronix" class="al-used-by-logo" style="height: 100%; width: 120px;">
</div>
</div>
</div>
</div>
This is a draft for #488, but it's got problems.