Remote website installation updates #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variables to variables.sh
* Do not truncate log file - it's helpful to see all the attempts a user made.
* Updates for shell conventions, e.g., ${1} instead of $1.
display_box() displays yesno, info, or msg boxes, depending on the first argument. This eliminates duplicate code.
Replaced all ${LOG_ONLY} with either --log or --logonly
Depending on user options, bold may turn characters lighter, not darker.
* Add file to OLD_FILES_TO_REMOVE * When aborting, display a text message instead of a dialog box. * Use --head in curl to avoid downloading huge files. * Various wording changes.
* Remove old "myImages" directory * Add "--user" option to display_aborted() to specify the USER aborted installation, versus an error aborted it. * Upon successful completion, display a text message instead of a 'dialog'. * Remove rundundant prompt for "do you want to continue". * Fix: check return code from upload.sh, not returned string.
Also, log delete failures
…eting a file "check" is more descriptive than passing in an unused URL.
It overwrites lines in the dialog box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many updates/fixes to the remote Website installation script.