type: add preliminiary support for singular vscale #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to support checking of programs with scalable vectors, add syntactic support for vscale and vscale_range, making the vscale an smt::expr in State. For the moment, we fail to type-check any program using scalable vectors.
Thread the vscale range information, which is an smt::expr in State to various functions in Type, cascading down to a final numElementsConst(), in preparation for the first step in supporting scalable vectors.
Change llvm_util to correctly fill aggregates and scalable vector splats, based on the vscale_range attribute on the function, and add a virtual numElementsConst() override, to operate on the maximum value in the vscale range. Not considering all possible vscale values is obviously a correctness issue, so ensure that we only pass the type-check when the vscale range has a singular value. In practice, the entire codebase needs to be taught about scalable vectors, before all programs with a singular vscale value are supported. The rem-costvscale.srctgt.ll test fails to type-check, for instance, due to ShuffleVector using a non-scalable mask. These instances are left as a todo for follow-up patches.
artagnon
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| children.resize(elements, &elementTy); | ||
| is_padding.resize(elements, false); | ||
| unsigned scaleFactor = isScalableTy ? var_vector_max_vscale : 1; | ||
| children.resize(elements * scaleFactor, &elementTy); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
| is_padding.resize(elements, false); | ||
| unsigned scaleFactor = isScalableTy ? var_vector_max_vscale : 1; | ||
| children.resize(elements * scaleFactor, &elementTy); | ||
| is_padding.resize(elements * scaleFactor, false); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
| @@ -1499,24 +1551,25 @@ | |||
| return 0; | |||
| } | |||
|
|
|||
| uint64_t getCommonAccessSize(const IR::Type &ty) { | |||
| uint64_t getCommonAccessSize(const IR::Type &ty, expr vscaleRange) { | |||
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change llvm_util to correctly fill aggregates and scalable vector splats, based on the vscale_range attribute on the function, and add a virtual numElementsConst() override, to operate on the maximum value in the vscale range. Not considering all possible vscale values is obviously a correctness issue, so ensure that we only pass the type-check when the vscale range has a singular value.
In practice, the entire codebase needs to be taught about scalable vectors, before all programs with a singular vscale value are supported. The rem-costvscale.srctgt.ll test fails to type-check, for instance, due to ShuffleVector using a non-scalable mask. These instances are left as a todo for follow-up patches.
-- 8< --
Based on #1139.