fix #980: UB executed with uitofp

AliveToolkit · Nov 29, 2023 · cdf792b · cdf792b
1 parent 6f95d8a
commit cdf792b
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/ir/type.cpp b/ir/type.cpp
@@ -446,24 +446,24 @@ expr FloatType::fromFloat(State &s, const expr &fp, const Type &from_type0,
 
   // 2) input NaN
   // 3) quieted input NaN
-  const FloatType &from_type = *from_type0.getAsFloatType();
+  const FloatType *from_type = from_type0.getAsFloatType();
 
   auto add_maybe_quiet = [&](const expr &e) {
     // account for fpext/fptruc
-    expr fraction = e.trunc(min(from_type.fractionBits(), fraction_bits));
+    expr fraction = e.trunc(min(from_type->fractionBits(), fraction_bits));
     if (fraction.bits() < fraction_bits)
       fraction = fraction.concat_zeros(fraction_bits - fraction.bits());
     assert(!fraction.isValid() || fraction.bits() == fraction_bits);
 
     expr truncated_is_nan = true;
-    if (from_type.fractionBits() > fraction_bits)
+    if (from_type->fractionBits() > fraction_bits)
       truncated_is_nan = fraction != 0;
 
     expr qnan = fraction.extract(fraction_bits - 1, fraction_bits - 1);
     expr quieted = var.extract(0, 0);
     qnan = expr::mkIf(truncated_is_nan, qnan | quieted, expr::mkUInt(1, 1));
     exprs.add(qnan.concat(fraction.trunc(fraction_bits - 1)),
-              from_type.getFloat(e).isNaN());
+              from_type->getFloat(e).isNaN());
   };
   if (nary >= 1) {
     add_maybe_quiet(a);