check that some parameter attributes are not changed

AliveToolkit · Apr 6, 2024 · 9b7d1ab · 9b7d1ab
1 parent 2fccad2
commit 9b7d1ab
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/ir/attrs.cpp b/ir/attrs.cpp
@@ -42,6 +42,8 @@ ostream& operator<<(ostream &os, const ParamAttrs &attr) {
     os << "zeroext ";
   if (attr.has(ParamAttrs::SignExt))
     os << "signext ";
+  if (attr.has(ParamAttrs::InReg))
+    os << "inreg ";
   if (attr.has(ParamAttrs::AllocPtr))
     os << "allocptr ";
   if (attr.has(ParamAttrs::AllocAlign))
@@ -299,6 +301,15 @@ bool ParamAttrs::refinedBy(const ParamAttrs &other) const {
   if ((bits & other_params) != other_params)
     return false;
 
+  // check attributes that cannot change
+  attrs =
+    SignExt |
+    ZeroExt |
+    InReg
+  ;
+  if ((bits & attrs) != (other.bits & attrs))
+    return false;
+
   return derefBytes == other.derefBytes &&
          derefOrNullBytes == other.derefOrNullBytes &&
          blockSize == other.blockSize &&

diff --git a/ir/attrs.h b/ir/attrs.h
@@ -65,8 +65,8 @@ class ParamAttrs final {
                    NoUndef = 1<<6, Align = 1<<7, Returned = 1<<8,
                    NoAlias = 1<<9, DereferenceableOrNull = 1<<10,
                    AllocPtr = 1<<11, AllocAlign = 1<<12,
-                   ZeroExt = 1<<13, SignExt = 1<<14, NoFPClass = 1<<15,
-                   IsArg = 1<<16 };
+                   ZeroExt = 1<<13, SignExt = 1<<14, InReg = 1<<15,
+                   NoFPClass = 1<<16, IsArg = 1<<17 };
 
   ParamAttrs(unsigned bits = None) : bits(bits) {}
 

diff --git a/llvm_util/llvm2alive.cpp b/llvm_util/llvm2alive.cpp
@@ -1352,11 +1352,8 @@ class llvm2alive_ : public llvm::InstVisitor<llvm2alive_, unique_ptr<Instr>> {
         continue;
 
       switch (llvmattr.getKindAsEnum()) {
-
-        // TODO: SignExt, ZeroExt, and InReg are not important for IR
-        // verification, but we should check that they don't change
-
       case llvm::Attribute::InReg:
+      attrs.set(ParamAttrs::InReg);
         break;
 
       case llvm::Attribute::SExt: