Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-7350: add logging for HttpFileUploader #274

Merged

Conversation

azakrzewski-hy
Copy link
Collaborator

@azakrzewski-hy azakrzewski-hy commented Apr 9, 2024

Copy link
Contributor

@mpichura mpichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error:  Failures: 
Error:    HttpHxInsightStorageClientTest.testUploadDataFromInputStream:86 
Argument(s) are different! Wanted:
fileUploaderMock.upload(
    FileUploadRequest[file=File[data=Mock for InputStream, hashCode: 424974506], contentType=plain/text, storageLocation=Mock for URL, hashCode: 837267422]
);
-> at org.alfresco.hxi_connector.live_ingester.adapters.messaging.hx_insight.storage.HttpHxInsightStorageClientTest.testUploadDataFromInputStream(HttpHxInsightStorageClientTest.java:86)
Actual invocations have different arguments:
fileUploaderMock.upload(
    FileUploadRequest[file=File[data=Mock for InputStream, hashCode: 424974506], contentType=plain/text, storageLocation=Mock for URL, hashCode: 837267422],
    "node-ref"
);
-> at org.alfresco.hxi_connector.live_ingester.adapters.messaging.hx_insight.storage.HttpHxInsightStorageClient.upload(HttpHxInsightStorageClient.java:64)

@azakrzewski-hy
Copy link
Collaborator Author

Error:  Failures: 
Error:    HttpHxInsightStorageClientTest.testUploadDataFromInputStream:86 
Argument(s) are different! Wanted:
fileUploaderMock.upload(
    FileUploadRequest[file=File[data=Mock for InputStream, hashCode: 424974506], contentType=plain/text, storageLocation=Mock for URL, hashCode: 837267422]
);
-> at org.alfresco.hxi_connector.live_ingester.adapters.messaging.hx_insight.storage.HttpHxInsightStorageClientTest.testUploadDataFromInputStream(HttpHxInsightStorageClientTest.java:86)
Actual invocations have different arguments:
fileUploaderMock.upload(
    FileUploadRequest[file=File[data=Mock for InputStream, hashCode: 424974506], contentType=plain/text, storageLocation=Mock for URL, hashCode: 837267422],
    "node-ref"
);
-> at org.alfresco.hxi_connector.live_ingester.adapters.messaging.hx_insight.storage.HttpHxInsightStorageClient.upload(HttpHxInsightStorageClient.java:64)

done in 260c2e1

Copy link
Member

@tpage-alfresco tpage-alfresco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Adam!

Copy link
Contributor

@mpichura mpichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@krdabrowski krdabrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I only propose one change to log message as it's a bit ambiguous IMO

@azakrzewski-hy azakrzewski-hy merged commit 82ce5a1 into master Apr 9, 2024
19 checks passed
@azakrzewski-hy azakrzewski-hy deleted the feature/ACS-7350-add-log-for-HttpFileUploader branch April 9, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants