-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS-7350: add logging for HttpFileUploader #274
ACS-7350: add logging for HttpFileUploader #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: Failures:
Error: HttpHxInsightStorageClientTest.testUploadDataFromInputStream:86
Argument(s) are different! Wanted:
fileUploaderMock.upload(
FileUploadRequest[file=File[data=Mock for InputStream, hashCode: 424974506], contentType=plain/text, storageLocation=Mock for URL, hashCode: 837267422]
);
-> at org.alfresco.hxi_connector.live_ingester.adapters.messaging.hx_insight.storage.HttpHxInsightStorageClientTest.testUploadDataFromInputStream(HttpHxInsightStorageClientTest.java:86)
Actual invocations have different arguments:
fileUploaderMock.upload(
FileUploadRequest[file=File[data=Mock for InputStream, hashCode: 424974506], contentType=plain/text, storageLocation=Mock for URL, hashCode: 837267422],
"node-ref"
);
-> at org.alfresco.hxi_connector.live_ingester.adapters.messaging.hx_insight.storage.HttpHxInsightStorageClient.upload(HttpHxInsightStorageClient.java:64)
...xi_connector/live_ingester/adapters/messaging/hx_insight/storage/connector/FileUploader.java
Outdated
Show resolved
Hide resolved
...onnector/live_ingester/adapters/messaging/hx_insight/storage/connector/HttpFileUploader.java
Show resolved
Hide resolved
done in 260c2e1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks Adam!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...onnector/live_ingester/adapters/messaging/hx_insight/storage/connector/HttpFileUploader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, I only propose one change to log message as it's a bit ambiguous IMO
ACS-7350