Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-20506 Rich Text Editor Visual Improvements #10385

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

JWollweber
Copy link

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation
  • Other... Please describe: Visual Improvements

What is the current behavior? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-20506
Chrome:
image
Firefox:
image

What is the new behavior?
Chrome:
image
Firefox:
image

  • Replaces the "Change Text Size" icon with one from material design icons
  • Improves the positioning of the "Change Text Color" icon
  • Makes sure the font color is not inherited by material design container
    • This increases contrast and therefore makes bold text more distinguishable (at least in the default case of black font color)
    • Makes sure the text in the editor looks more like the final result in the form

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Other information:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sonarcloud bot commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants