Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2251 Fix PR automation and better PR title #114

Merged
merged 1 commit into from
Oct 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/bumpVersions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
version: v0.54.0

- name: Set ENV
- name: Set required environment variables
run: |
echo "TOMCAT_MAJOR=${{ matrix.tomcat_major }}" >> $GITHUB_ENV
echo "TOMCAT_VERSION=$(jq -r '.tomcat_version' tomcat${{ matrix.tomcat_major }}.json)" >> $GITHUB_ENV
Expand All @@ -48,7 +48,7 @@ jobs:
- uses: stefanzweifel/git-auto-commit-action@v4
id: auto-commit-action
with:
branch: bump-tomcat${{ matrix.tomcat_major }}
branch: bump-tomcat-${{ env.TOMCAT_VERSION }}
create_branch: true
push_options: '--force'
commit_user_name: ${{ vars.BOT_GITHUB_USERNAME }}
Expand All @@ -58,7 +58,7 @@ jobs:
if: steps.auto-commit-action.outputs.changes_detected == 'true'
run: |
if ! gh pr view --json url --jq .url; then
gh pr create --title "Bump tomcat${{ matrix.tomcat_major }}" --body "Freshly served thanks to updatecli and GitHub Actions"
gh pr create --title "Bump tomcat to ${{ env.TOMCAT_VERSION }}" --body "Freshly served thanks to updatecli and GitHub Actions"
fi
env:
GH_TOKEN: ${{ secrets.BOT_GITHUB_TOKEN }}