Exception -> BaseException

AlexWaygood · Nov 13, 2023 · e0c88f0 · e0c88f0
1 parent e4e968a
commit e0c88f0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
@@ -7534,7 +7534,7 @@ class Foo(NamedTuple):
         self.assertEqual(foo.attr.name, "attr")
 
     def test_setname_raises_the_same_as_on_other_classes(self):
-        class CustomException(Exception): pass
+        class CustomException(BaseException): pass
 
         class Annoying:
             def __set_name__(self, owner, name):

diff --git a/Lib/typing.py b/Lib/typing.py
@@ -2734,7 +2734,7 @@ def __new__(cls, typename, bases, ns):
                 if hasattr(type(val), "__set_name__"):
                     try:
                         type(val).__set_name__(val, nm_tpl, key)
-                    except Exception as e:
+                    except BaseException as e:
                         e.add_note(
                             f"Error calling __set_name__ on {type(val).__name__!r} "
                             f"instance {key!r} in {typename!r}"