Skip to content

Commit

Permalink
a
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexSkrypnyk committed Nov 20, 2024
1 parent 7b82264 commit 9ce8201
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
1 change: 1 addition & 0 deletions .devtools/assemble.sh
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ pass "Suggested dependencies installed."
# deprecation notices.
# @see https://www.drupal.org/project/drupal/issues/1267246
if [ "${SYMFONY_DEPRECATIONS_HELPER-}" == "disabled" ]; then
note "Disabling deprecation notices in the functional tests."
echo "error_reporting(E_ALL & ~E_DEPRECATED);" >>build/web/sites/default/default.settings.php

Check warning on line 175 in .devtools/assemble.sh

View check run for this annotation

Codecov / codecov/patch

.devtools/assemble.sh#L174-L175

Added lines #L174 - L175 were not covered by tests
fi

Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@ jobs:
php-version: ${{ matrix.php-version }}
extensions: gd, sqlite, pdo_sqlite

# Disable Symfony deprecations helper for PHP 8.4+ until minor
# versions of Drupal 10 and 11 core fully support PHP 8.4+.
# @see https://www.drupal.org/project/drupal/issues/1267246
- name: Update SYMFONY_DEPRECATIONS_HELPER for PHP 8.4+
run: echo "SYMFONY_DEPRECATIONS_HELPER=$([[ "${{ matrix.php-version }}" < "8.4" ]] && echo 'disabled' || echo '')" >> $GITHUB_ENV

- name: Assemble the codebase
run: .devtools/assemble.sh
env:
Expand Down Expand Up @@ -145,11 +151,6 @@ jobs:
run: vendor/bin/phpunit || [ "${CI_TEST_IGNORE_FAILURE:-0}" -eq 1 ]
env:
BROWSERTEST_OUTPUT_DIRECTORY: /tmp
# Disable Symfony deprecations helper for PHP 8.4+ until minor
# versions of Drupal 10 and 11 core fully support PHP 8.4+.
# @see https://www.drupal.org/project/drupal/issues/1267246
# SYMFONY_DEPRECATIONS_HELPER: ${{ matrix.php-version < '8.4' && 'disabled' }}
SYMFONY_DEPRECATIONS_HELPER: 'disabled'

- name: Upload test results as an artifact
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit 9ce8201

Please sign in to comment.