Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global hotkeys to change Gmode&&add plot widget #38

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

AprDeci
Copy link
Contributor

@AprDeci AprDeci commented Aug 28, 2024

Added a global hotkey (tested with G15 5511's G key) to quickly switch G modes
Added a plot widget which could mouse interactive to change the curve(I haven't written any code about temperature control in the main program yet)

@AprDeci
Copy link
Contributor Author

AprDeci commented Aug 28, 2024

I also add a window toast to show the current mode switching

@AprDeci AprDeci changed the title add global hotkeys to change Gmode add global hotkeys to change Gmode&&add plot widget Aug 31, 2024
@AprDeci
Copy link
Contributor Author

AprDeci commented Aug 31, 2024

The plot widget will conflict with your slider widget. If you are willing to merge my PR, I want to know what you think of the conflict

@AlexIII
Copy link
Owner

AlexIII commented Sep 15, 2024

Hi! Thank you for the contribution!
After a read through the proposed changes, I cannot directly accept the PR due to some technical problems with the code, but I will review / make changes and will credit you as the commit co-author when I merge to the main branch.
Very nice work overall.

@AprDeci
Copy link
Contributor Author

AprDeci commented Sep 15, 2024

Hi! Thank you for the contribution! After reviewing the proposed changes, I cannot directly accept the PR due to some technical issues with the code, but I will review/make changes and will credit you as the commit co-author when I merge to the main branch. Very nice work overall.

Thanks for your reply, I'm not a professional Python developer,so I absolutely agree you to change the code(I also think my code is not good)

@AlexIII
Copy link
Owner

AlexIII commented Sep 16, 2024

Parts of this PR (support for G mode hotkey) were included in 1.6.0 release.
Your contribution is reflected in #786fbc4 and #d606fe3 https://github.com/AlexIII/tcc-g15/commits/master/
I will review the remaining functionality (fan curves) a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants