Use execute_function for nested calls in CallStack::PackageRun #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We only need to use
execute_functioninstead ofevaluate_functionwhen usingPackageRun.Why did this happen? Because we "simply" never properly set up
evaluate_functionto properly handle nested calls, and I didn't spot the failed test in the previous PR. Made an issue in case we want to fix this in the future: https://github.com/AleoHQ/snarkVM/issues/2287Fortunately, this adjustment won't have a performance hit for
CheckDeployments.Test Plan
Existing test suite should pass. Locally everything succeeds but CI has a flaky test, made an issue for it: https://github.com/AleoHQ/snarkVM/issues/2286
Related PRs
https://github.com/AleoHQ/snarkVM/pull/2230