[7.4-stable] Convert dialog class into esm #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last module before we can convert it's parent the Dialog. (cherry picked from commit 7221f54)
The last CoffeeScript file and last JS file we compile with Sprockets. We can now remove Sprockets. (cherry picked from commit 3e3ad98)
We do not compile any JS with Sprockets anymore \o/ (cherry picked from commit e63f266)
Alchemy.GUI.init is only used in this module. Combining it into the Initializer allows to reduce the dependencies of the Dialog class. (cherry picked from commit 3389b03)
Try to adhere code climate issues (cherry picked from commit 881a5f9)
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.4-stable #3119 +/- ##
===========================================
Coverage 96.47% 96.47%
===========================================
Files 237 237
Lines 6406 6406
===========================================
Hits 6180 6180
Misses 226 226 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.4-stable:Questions ?
Please refer to the Backport tool documentation