Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4-stable] Use cropperjs instead of Jcrop #3116

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 3, 2025

Backport

This will backport the following commits from main to 7.4-stable:

Questions ?

Please refer to the Backport tool documentation

JCrop is not maintained anymore and uses jQuery.
Cropperjs is a maintained jQuery-less alternative.

(cherry picked from commit 7233e12)

# Conflicts:
#	app/assets/builds/alchemy/admin.css
#	app/assets/builds/alchemy/admin.css.map
#	bun.lockb
#	package.json
@tvdeyen tvdeyen requested a review from a team as a code owner January 3, 2025 23:35
@tvdeyen tvdeyen mentioned this pull request Jan 3, 2025
2 tasks
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (bec7c31) to head (dfb492e).
Report is 5 commits behind head on 7.4-stable.

Additional details and impacted files
@@              Coverage Diff               @@
##           7.4-stable    #3116      +/-   ##
==============================================
- Coverage       96.47%   96.47%   -0.01%     
==============================================
  Files             237      237              
  Lines            6408     6407       -1     
==============================================
- Hits             6182     6181       -1     
  Misses            226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 1328217 into 7.4-stable Jan 3, 2025
36 checks passed
@tvdeyen tvdeyen deleted the backport/7.4-stable/pr-3047 branch January 3, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant