Fix image_overlay hidden form style #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can fix some bugs with calc and Sass var interpolation and make way for some refactorings.
Prevents scrllbars if image overlay is open and the form is hidden. Also fixes the next image arrow transition effect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6334 6334
=======================================
Hits 6118 6118
Misses 216 216 ☔ View full report in Codecov by Sentry. |
mamhoff
approved these changes
Jan 3, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Prevents scrollbars if image overlay is open and the form is
hidden. Also fixes the next image arrow transition effect.
Checklist