Use an inner select for CanCanCan abilities #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Nov 29, 2024
The previous solution only worked if the pg_search_document had a page_id. If another search document without a page relation was added and an ability was present, the document couldn't be found, because the generate SQL had an inner join that was using the page_id. The new solution is using a sub select and only filters pg_search_documents if the page_id is present on that document entries.
sascha-karnatz
force-pushed
the
allow-multiple-abilities
branch
from
8a77571 to
4d263ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution only worked if the pg_search_document has a page_id. If another search document without a page relation was added and a ability was present, the document couldn't be found, because the generate SQL had an inner join to that page_id. The new solution is using a sub select and only filters pg_search_documents, that have a page_id relation.