Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicating Alchemy.publish_targets in development environment #40

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Avoid duplicating Alchemy.publish_targets in development environment #40

merged 1 commit into from
Feb 5, 2024

Conversation

dbwinger
Copy link
Contributor

No description provided.

tvdeyen
tvdeyen reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. For now this should be fine (with a little refactoring), but ideally we would fix this in Alchemy and use a Set for the publish targets.

lib/alchemy/pg_search/engine.rb Outdated Show resolved Hide resolved
@dbwinger dbwinger force-pushed the dupe-publish-targets branch from b7416d1 to caabcce Compare September 29, 2023 10:26
@dbwinger
Copy link
Contributor Author

Thanks. For now this should be fine (with a little refactoring), but ideally we would fix this in Alchemy and use a Set for the publish targets.

FYI, Alchemy.publish_targets already is using Set but apparently it's not considering the multiple additions as duplicates.

@tvdeyen tvdeyen merged commit dd5a9c8 into AlchemyCMS:main Feb 5, 2024
@tvdeyen
Copy link
Member

tvdeyen commented Feb 5, 2024

@dbwinger released as 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwinger @tvdeyen