Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: revert all previous changes #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Nov 1, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhancements:

  • Simplify the table rendering logic by removing the 'updated' lifecycle method and integrating header and row extraction directly into the rendering process.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner November 1, 2024 03:48
Copy link

sourcery-ai bot commented Nov 1, 2024

Reviewer's Guide by Sourcery

This PR refactors the table component implementation by replacing imperative DOM manipulation with a declarative template-based approach. The changes improve performance by eliminating unnecessary DOM operations and leveraging Lit's efficient rendering system.

Updated class diagram for AuroTable

classDiagram
    class AuroTable {
        +firstUpdated()
        +extractRows(columns, data) Array
        +render() html
    }
    note for AuroTable "Refactored to use a declarative template-based approach for rendering tables."
Loading

File-Level Changes

Change Details Files
Replaced imperative DOM manipulation with declarative template rendering
  • Removed separate extractHeaders() method that manually created TH elements
  • Refactored extractRows() to return data structure instead of manipulating DOM
  • Implemented template-based rendering using Lit's html template literal
  • Removed lifecycle hook 'updated' in favor of reactive rendering
src/auro-table.js
Improved table rendering logic
  • Added conditional rendering to return empty template when required props are missing
  • Implemented row and cell rendering using array mapping
  • Added proper handling of column headers in the template
src/auro-table.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jason-capsule42 jason-capsule42 self-assigned this Nov 1, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The commit message 'perf: revert all previous changes' doesn't accurately describe the changes. This appears to be a refactor from imperative DOM manipulation to declarative lit-html templates. Please update the commit message to reflect the actual changes.
  • If this change is performance-related as suggested by the 'perf:' prefix, please include performance benchmarks comparing the old and new implementations.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant