-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: revert all previous changes #100
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR refactors the table component implementation by replacing imperative DOM manipulation with a declarative template-based approach. The changes improve performance by eliminating unnecessary DOM operations and leveraging Lit's efficient rendering system. Updated class diagram for AuroTableclassDiagram
class AuroTable {
+firstUpdated()
+extractRows(columns, data) Array
+render() html
}
note for AuroTable "Refactored to use a declarative template-based approach for rendering tables."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The commit message 'perf: revert all previous changes' doesn't accurately describe the changes. This appears to be a refactor from imperative DOM manipulation to declarative lit-html templates. Please update the commit message to reflect the actual changes.
- If this change is performance-related as suggested by the 'perf:' prefix, please include performance benchmarks comparing the old and new implementations.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Enhancements: