Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auro-library as a regular dependency instead of a dev dependency #142

Conversation

DukeFerdinand
Copy link
Contributor

Alaska Airlines Pull Request

Moves Auro Library into dependencies from devDependencies to avoid installation issues, as originally reported in #573.

Resolves: #141

Summary:

  • Moved to dependencies within package.json
  • Regenerated package.lock
  • Verified build and test ran successfully

Type of change:

Please delete options that are not relevant.

  • Revision of an existing capability

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@DukeFerdinand DukeFerdinand requested review from chrisfalaska and a team October 8, 2024 18:49
@DukeFerdinand DukeFerdinand linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@DukeFerdinand DukeFerdinand changed the title fix: make auro-library a normal dep instead of devDep Add auro-library as a regular dependency instead of a dev dependency Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Surge demo deployment failed! 😭

chrisfalaska
chrisfalaska previously approved these changes Oct 9, 2024
Lock the version to 2.8.x and increase build compatibility with other repositories.
@DukeFerdinand DukeFerdinand merged commit c26d0c3 into main Oct 14, 2024
6 of 7 checks passed
@DukeFerdinand DukeFerdinand deleted the dhook/141-auro-library-incorrectly-installed-in-devdependencies branch October 14, 2024 20:55
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auro Library incorrectly installed in devDependencies
3 participants