Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jbaker/theme support #132

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Jbaker/theme support #132

merged 4 commits into from
Jul 4, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented May 31, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #124

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • No linter issues
  • All automated tests pass
  • New Tier 3 component token exists
  • API Page "Theme" section is valid

Radio Buttons

  • default state (no error, not checked, not disabled renders correctly
  • checked state renders correctly
  • error state renders correctly
  • checked and error state renders correctly
  • disabled state renders correctly

Radio Group

  • disabled state renders label correctly
  • disabled state renders help text correctly
  • error state renders label correctly
  • error state renders help text correctly
  • Tabbing to the group highlights the first radio button if none are checked
  • Tabbing to the group highlights the checked radio button if one exists
  • Using the arrow keys to navigate radio buttons renders the active radio button correctly

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jason-capsule42 jason-capsule42 self-assigned this May 31, 2024
@jason-capsule42 jason-capsule42 linked an issue May 31, 2024 that may be closed by this pull request
Copy link

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

@jason-capsule42 jason-capsule42 changed the base branch from main to beta June 26, 2024 21:51
@jason-capsule42 jason-capsule42 marked this pull request as ready for review June 27, 2024 17:01
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple additional things:

  • Update the eslint stuff and address all warnings in console
  • Update the type for events in jsdocs from @fires to @event`
  • Update the commit history to merge together the two commits that have the exact same wording
  • Update the theming commit to include the ticket number

src/tokens.scss Outdated Show resolved Hide resolved
src/tokens.scss Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
src/tokens.scss Outdated Show resolved Hide resolved
src/groupColor.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
src/groupColor.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last review submitted was accidentally set to comments, requesting changes now

@jason-capsule42 jason-capsule42 force-pushed the jbaker/themeSupport branch 2 times, most recently from a444d6b to c7d6b45 Compare July 4, 2024 16:15
@jason-capsule42 jason-capsule42 merged commit 1df0f6e into beta Jul 4, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/themeSupport branch July 4, 2024 16:22
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
3 participants