-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbaker/theme support #132
Jbaker/theme support #132
Conversation
Surge demo deployment succeeded! 🚀🚀🚀 |
b155ea1
to
3d1cfe8
Compare
68bdba6
to
3557063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple additional things:
- Update the eslint stuff and address all warnings in console
- Update the type for events in jsdocs from
@fires
to @event` - Update the commit history to merge together the two commits that have the exact same wording
- Update the theming commit to include the ticket number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last review submitted was accidentally set to comments, requesting changes now
a444d6b
to
c7d6b45
Compare
c7d6b45
to
cd88ec0
Compare
🎉 This PR is included in version 3.1.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #124
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
Verification
Radio Buttons
default
state (no error, not checked, not disabled renders correctlychecked
state renders correctlyerror
state renders correctlychecked
anderror
state renders correctlydisabled
state renders correctlyRadio Group
disabled
state renders label correctlydisabled
state renders help text correctlyerror
state renders label correctlyerror
state renders help text correctlyBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team