Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync CTA Button and auro-button tier 3 tokens #234

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Nov 6, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #213

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Synchronize CTA button design tokens with auro-button tier 3 tokens and update dependencies.

Enhancements:

  • Update design tokens for CTA buttons to align with auro-button tier 3 tokens.

Build:

  • Upgrade dependencies in package.json, including @aurodesignsystem/auro-icon and lit.

@jordanjones243 jordanjones243 self-assigned this Nov 6, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner November 6, 2024 19:51
Copy link

sourcery-ai bot commented Nov 6, 2024

Reviewer's Guide by Sourcery

This PR updates the CTA button and auro-button tier 3 tokens to align with the latest design system standards. The changes primarily involve updating color token references and dependencies, with a focus on improving consistency across different button states (default, hover, focus, etc.) in both light and dark themes.

Class diagram for updated token references

classDiagram
    class Token {
        +String ctaDefaultColor
        +String ctaDefaultContainerColor
        +String ctaDefaultOutlineColor
        +String ctaDefaultBorderColor
        +String ctaVisitedColor
        +String ctaVisitedContainerColor
        +String ctaVisitedOutlineColor
        +String ctaVisitedBorderColor
        +String ctaFocusColor
        +String ctaFocusContainerColor
        +String ctaFocusOutlineColor
        +String ctaFocusBorderColor
        +String ctaHoverColor
        +String ctaHoverContainerColor
        +String ctaHoverOutlineColor
        +String ctaHoverBorderColor
    }
    note for Token "Updated color token references for CTA buttons to align with design system standards."
Loading

File-Level Changes

Change Details Files
Updated color token references for CTA buttons to use the new primary and secondary container colors
  • Changed default container colors to use primary container tokens
  • Updated hover state colors to match new container color scheme
  • Modified focus state outline and border colors for better consistency
  • Aligned inverse (dark theme) color tokens with the new system
src/tokens.scss
Modified icon handling and styling
  • Replaced hardcoded icon size values with design tokens
  • Removed customSize attribute from icon template
  • Updated icon spacing and layout properties
src/style.scss
src/component-base.mjs
Updated package dependencies to latest versions
  • Upgraded auro-icon to version 6.0.2
  • Updated various dev dependencies to their latest versions
  • Added nodeResolve plugin to rollup configs
package.json
rollup.config.mjs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jordanjones243 jordanjones243 merged commit 217c20f into main Nov 6, 2024
6 checks passed
@jordanjones243 jordanjones243 deleted the jjones/ctaButtonColors/#123 branch November 6, 2024 21:59
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button and Hyperlink CTA should use the same semantic tokens
3 participants