Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csspart to auro-icon #226

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Add csspart to auro-icon #226

merged 2 commits into from
Oct 1, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Oct 1, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #227

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Add a CSS part to the auro-icon component to enable more detailed styling options.

New Features:

  • Introduce a CSS part named 'targetIcon' to the auro-icon component, allowing for more granular styling.

@jordanjones243 jordanjones243 self-assigned this Oct 1, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner October 1, 2024 21:49
Copy link

sourcery-ai bot commented Oct 1, 2024

Reviewer's Guide by Sourcery

This pull request adds a CSS part to the auro-icon component, allowing for more flexible styling of the icon from outside the component. The change is implemented by modifying the render method of the icon to include a 'part' attribute.

Class diagram for ComponentBase changes

classDiagram
    class ComponentBase {
        - LitElement
        + render(): html
    }
    ComponentBase : +iconTag
    ComponentBase : +customColor
    ComponentBase : +customSize
    ComponentBase : +customSvg
    ComponentBase : +part="targetIcon"
    ComponentBase --> LitElement
Loading

File-Level Changes

Change Details Files
Added CSS part to auro-icon component
  • Removed separate variable for iconHtml
  • Added 'part="targetIcon"' attribute to the icon element
  • Simplified the return statement by directly returning the html template literal
src/component-base.mjs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The code change looks good, but could you please provide more context in the PR description? It would be helpful to understand the motivation behind adding the 'part' attribute and how it will be used.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

jason-capsule42
jason-capsule42 previously approved these changes Oct 1, 2024
.github/settings.yml Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 merged commit eda1550 into main Oct 1, 2024
6 checks passed
@jordanjones243 jordanjones243 deleted the jjones/addParts branch October 1, 2024 22:06
@blackfalcon
Copy link
Member

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add css part to target icon
3 participants