-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add csspart to auro-icon #226
Conversation
Reviewer's Guide by SourceryThis pull request adds a CSS part to the auro-icon component, allowing for more flexible styling of the icon from outside the component. The change is implemented by modifying the render method of the icon to include a 'part' attribute. Class diagram for ComponentBase changesclassDiagram
class ComponentBase {
- LitElement
+ render(): html
}
ComponentBase : +iconTag
ComponentBase : +customColor
ComponentBase : +customSize
ComponentBase : +customSvg
ComponentBase : +part="targetIcon"
ComponentBase --> LitElement
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jordanjones243 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The code change looks good, but could you please provide more context in the PR description? It would be helpful to understand the motivation behind adding the 'part' attribute and how it will be used.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
a350135
to
bc78c1a
Compare
7e65aab
to
8bb8afd
Compare
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #227
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a CSS part to the auro-icon component to enable more detailed styling options.
New Features: