-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update markdown partial pathing to consume new auro lib #72 #73
Conversation
Reviewer's Guide by SourceryThis PR updates the markdown partial paths to align with the new auro library structure and enhances the build configuration. The changes primarily involve updating file paths in markdown files and adding the nodeResolve plugin to Rollup for better module resolution. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to resolve remaining Sourcery review comments - there is a typo in there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After running the local run dev
, the image under the "Recommended Use and Version Control" appears to be different from the DocSite:
Local version:
Docsite is the one that has a bug :) |
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #72
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Update markdown partial paths to align with the new auro library structure and enhance build configuration with updated dependencies and plugins.
Bug Fixes:
Enhancements:
Build:
Summary by Sourcery
Fix markdown partial paths to accommodate the new auro library structure and enhance the build configuration by updating dependencies and adding the nodeResolve plugin to Rollup.
Bug Fixes:
Enhancements:
Build:
Summary by Sourcery
Fix markdown partial paths to accommodate the new auro library structure and enhance the build configuration by updating dependencies and adding the nodeResolve plugin to Rollup.
Bug Fixes:
Enhancements:
Build: